Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Improves SSR error logging across documentation and examples to fix improper logging format. The change addresses an issue where Rslog only formats the first parameter by default, so passing the error as a second parameter resulted in poor error display.
- Split single
logger.error()calls into two separate calls for better error formatting - Updated both English and Chinese documentation examples
- Applied the same fix to E2E test configurations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/advanced/ssr.mdx | Updated Chinese SSR documentation example to use proper error logging format |
| website/docs/zh/guide/advanced/environments.mdx | Updated Chinese environments documentation example for better error logging |
| website/docs/en/guide/advanced/ssr.mdx | Updated English SSR documentation example to use proper error logging format |
| website/docs/en/guide/advanced/environments.mdx | Updated English environments documentation example for better error logging |
| e2e/cases/server/ssr/rsbuild.config.ts | Applied error logging fix to SSR E2E test configuration |
| e2e/cases/server/ssr-type-module/rsbuild.config.ts | Applied error logging fix to SSR type module E2E test configuration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the SSR error logging example. Improve the SSR error logging example. Rslog only formats the first parameter by default, so we should not pass err as the second parameter of
logger.error.Before
After
Checklist