fix: enhance inline query regex to support more patterns#5939
Merged
chenjiahan merged 1 commit intomainfrom Aug 24, 2025
Merged
fix: enhance inline query regex to support more patterns#5939chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the inline query regex pattern to support more flexible inline query formats. The update changes the regex from matching only ?inline at the start of query strings to matching ?inline, ?inline=value, ?inline&other=value, and ?other=value&inline patterns.
- Updates
INLINE_QUERY_REGEXfrom/^\?inline$/to/[?&]inline(?:&|=|$)/across multiple plugins and core - Adds comprehensive test coverage for all supported inline query patterns
- Updates snapshot tests to reflect the new regex pattern
Reviewed Changes
Copilot reviewed 15 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/constants.ts | Updates INLINE_QUERY_REGEX constant and adds documentation |
| packages/plugin-sass/src/index.ts | Updates regex pattern in Sass plugin |
| packages/plugin-less/src/index.ts | Updates regex pattern in Less plugin |
| packages/plugin-stylus/src/index.ts | Updates regex pattern in Stylus plugin |
| e2e/cases/css/inline-query/src/index.js | Adds test imports for different inline query patterns |
| e2e/cases/css/inline-query/index.test.ts | Updates tests to verify all supported inline query formats |
| Various snapshot files | Updates test snapshots to reflect the new regex pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
INLINE_QUERY_REGEXto match more patterns, such as?inline,?inline=1,?inline&other=value, and?other=value&inline, instead of only?inlineat the start of the query string.Related Links
Checklist