Skip to content

chore: add copilot-instructions.md for GitHub Copilot coding agent#5891

Merged
chenjiahan merged 4 commits intomainfrom
copilot/fix-5890
Aug 20, 2025
Merged

chore: add copilot-instructions.md for GitHub Copilot coding agent#5891
chenjiahan merged 4 commits intomainfrom
copilot/fix-5890

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Aug 20, 2025

This PR adds streamlined instructions for GitHub Copilot coding agents working in the Rsbuild repository. The instructions provide essential guidance on setup, development workflows, and repository navigation in a concise format.

Key Features

Setup & Build Instructions:

  • Complete setup workflow with timing expectations
  • Essential commands for Node.js/pnpm setup and builds
  • "NEVER CANCEL" warnings for long-running operations

Development Workflows:

  • Testing procedures (unit tests, E2E, linting)
  • CLI development and validation steps
  • Repository structure and key file locations

Concise Format:

  • Reduced to 66 lines for quick reference
  • Consolidated related information
  • Preserved all essential commands and timing details

The instructions follow an imperative tone and include timeout recommendations to prevent premature cancellation of long-running operations.

Fixes #5890.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Aug 20, 2025

@chenjiahan 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 20, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ba13184
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68a55acc2f66e2000855a775
😎 Deploy Preview https://deploy-preview-5891--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 20, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chenjiahan
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: chenjiahan <7237365+chenjiahan@users.noreply.github.com>
Copilot AI changed the title [WIP] ✨ Set up Copilot instructions feat: Add .github/copilot-instructions.md for GitHub Copilot coding agent Aug 20, 2025
Copilot AI requested a review from chenjiahan August 20, 2025 04:56
@chenjiahan
Copy link
Copy Markdown
Member

@copilot Make this guide more concise

Co-authored-by: chenjiahan <7237365+chenjiahan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Aug 20, 2025

@copilot Make this guide more concise

Made the guide more concise - reduced from 185 lines to 66 lines (64% reduction) while preserving all essential information. Consolidated related sections, removed redundant formatting, and streamlined the structure. Commit: 568d8ea

Copilot AI changed the title feat: Add .github/copilot-instructions.md for GitHub Copilot coding agent feat: Add concise .github/copilot-instructions.md for GitHub Copilot coding agent Aug 20, 2025
@chenjiahan chenjiahan changed the title feat: Add concise .github/copilot-instructions.md for GitHub Copilot coding agent chore: add copilot-instructions.md for GitHub Copilot coding agent Aug 20, 2025
@chenjiahan chenjiahan marked this pull request as ready for review August 20, 2025 05:19
Copilot AI review requested due to automatic review settings August 20, 2025 05:19
@chenjiahan chenjiahan merged commit 4e85429 into main Aug 20, 2025
11 of 12 checks passed
@chenjiahan chenjiahan deleted the copilot/fix-5890 branch August 20, 2025 05:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a concise reference guide for GitHub Copilot coding agents working in the Rsbuild repository. The instructions provide essential setup procedures, development workflows, and repository navigation guidance in a streamlined 54-line format.

Key changes:

  • Added comprehensive setup instructions with timing expectations and "NEVER CANCEL" warnings
  • Included development workflow commands for testing, building, and code quality checks
  • Provided repository structure overview with key directories and their purposes

```bash
pnpm test # Unit tests (~10s)
pnpm e2e # E2E tests (~60s)
pnpm lint # Lint code (~5s) - REQUIRED before finishing
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'REQUIRED before finishing' is ambiguous. Consider clarifying what 'finishing' means - is this before committing, before submitting a PR, or before completing development work?

Suggested change
pnpm lint # Lint code (~5s) - REQUIRED before finishing
pnpm lint # Lint code (~5s) - REQUIRED before committing or submitting a pull request

Copilot uses AI. Check for mistakes.

- Rsbuild CLI commands: `dev`, `build`, `preview`, `inspect`
- Uses NX for builds, Rslib for bundling
- Node.js 22+
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js version requirement appears incomplete. Consider adding context about whether this is a minimum requirement and if it's consistent with the project's package.json engines field.

Suggested change
- Node.js 22+
- Requires Node.js >=22 (see `package.json` `engines` field)

Copilot uses AI. Check for mistakes.
@chenjiahan chenjiahan mentioned this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Set up Copilot instructions

4 participants