chore: remove unnecessary exports and helpers#5887
Merged
chenjiahan merged 1 commit intomainfrom Aug 20, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary exported functions, constants, and dependencies to improve code clarity and maintainability by reducing the public API surface and eliminating unused code.
- Remove unused helper function and constant exports
- Convert public exports to private functions/constants where external access isn't needed
- Clean up unused React dependencies in webpack example
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-babel/src/plugin.ts | Convert exported constant to private constant |
| packages/core/src/server/runner/index.ts | Convert exported class to private class |
| packages/core/src/server/hmrFallback.ts | Convert exported function to private function |
| packages/core/src/rspack-plugins/RsbuildHtmlPlugin.ts | Convert exported constant to private constant |
| packages/core/src/plugins/swc.ts | Convert exported function to private function |
| packages/core/src/hooks.ts | Convert exported function to private function |
| packages/core/src/helpers/index.ts | Remove unused helper function export |
| packages/core/src/constants.ts | Remove unused constant export |
| packages/compat/plugin-webpack-swc/src/utils.ts | Convert exported function to private function |
| examples/webpack/package.json | Remove unused React dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve code clarity and consistency by removing unnecessary exports and dependencies.
Checklist