test(e2e): simplify runtime log assertions#5874
Merged
chenjiahan merged 1 commit intomainfrom Aug 18, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test assertions to use the expectLog helper instead of expectPoll for cleaner and more specific log-based assertions in e2e tests.
- Replace manual log array management with the
createLogMatcherhelper - Simplify log pattern matching by using
expectLoginstead ofexpectPoll - Enhance
LogPatterntype to support function-based matching
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/helper/logs.ts | Enhanced LogPattern type to support function patterns and updated type signatures |
| e2e/cases/server/overlay/index.test.ts | Replaced manual log handling and expectPoll with createLogMatcher and expectLog |
| e2e/cases/server/overlay-type-errors/index.test.ts | Simplified log assertions using expectLog instead of expectPoll |
| e2e/cases/plugin-api/plugin-transform-error-handle/index.test.ts | Used built-in expectLog method from rsbuild instance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
expectPollwith theexpectLoghelper for cleaner test assertions.Checklist