test(e2e): add test case for using declaration syntax#5873
Merged
chenjiahan merged 2 commits intomainfrom Aug 18, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new end-to-end test case to verify TypeScript's using declaration syntax for explicit resource management, while also cleaning up TypeScript configuration files by removing unused compiler options.
- Adds test case for
usingandawait usingdeclarations including for-loop variants - Cleans up tsconfig.json files by removing unused JSX and path mapping options
- Tests disposal mechanism by counting dispose calls on resources
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| e2e/cases/syntax/using-declaration/src/index.ts | Implements test scenarios for using declarations with disposal tracking |
| e2e/cases/syntax/using-declaration/index.test.ts | Test runner that validates dispose counter equals 4 |
| e2e/cases/syntax/using-declaration/tsconfig.json | TypeScript configuration for the new test case |
| e2e/cases/typescript/type-re-exports/tsconfig.json | Removes unused JSX and path mapping options |
| e2e/cases/typescript/const-enum/tsconfig.json | Removes unused JSX and path mapping options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add new test case to verify explicit resource management with
usingdeclaration.Related Links
web-infra-dev/rspack#11395
Checklist