test(e2e): standardize log assertions and improving reliability#5869
Merged
chenjiahan merged 4 commits intomainfrom Aug 18, 2025
Merged
test(e2e): standardize log assertions and improving reliability#5869chenjiahan merged 4 commits intomainfrom
chenjiahan merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes log assertions throughout the e2e test suite by refactoring the log handling utilities and replacing manual log inspections with a centralized expectLog() helper, improving test reliability and maintainability.
Key changes:
- Moved log handling utilities from
scripts/tohelper/directory with improved structure - Created a new
createLogMatcher()utility that provides standardized log assertion methods - Replaced manual log array inspections with the new
expectLog()helper across 25+ test files
Reviewed Changes
Copilot reviewed 30 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/tsconfig.json | Updated include path from "scripts" to "helper" |
| e2e/scripts/package.json | Removed old package.json from scripts directory |
| e2e/scripts/cli.ts | Removed old CLI utilities file |
| e2e/helper/utils.ts | Removed legacy proxyConsole and matchPattern utilities |
| e2e/helper/package.json | Added new package.json with picocolors dependency |
| e2e/helper/logs.ts | New centralized log handling utilities with createLogMatcher |
| e2e/helper/jsApi.ts | Updated to use new log utilities and removed captureLogs options |
| e2e/helper/index.ts | Updated exports to include new log utilities |
| e2e/helper/cli.ts | New CLI utilities using standardized log matching |
| e2e/cases/*/*.test.ts | Multiple test files updated to use expectLog() instead of manual log inspection |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsbuild.expectLog()helper and improving reliability.Checklist