test(e2e): simplify profile test cases by using helpers#5865
Merged
chenjiahan merged 1 commit intomainfrom Aug 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Simplifies profile-related e2e test cases by replacing manual child process handling with helper utilities.
- Refactors two rspack profile test cases to use
runCommandandrunClihelpers - Adds
getLogsmethod to therunCommandhelper function - Removes manual stdout data handling and process spawning in favor of the standardized helpers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e/scripts/shared.ts | Adds getLogs method to return accumulated logs from the command helper |
| e2e/cases/rspack-profile/index.test.ts | Refactors profile tests to use helper functions instead of manual process management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace manual child process handling with
runCommandandrunClihelpers in the profile related e2e cases.Checklist