fix(server): handle Deno compatibility in public dir copy#5852
Merged
chenjiahan merged 1 commit intomainfrom Aug 15, 2025
Merged
fix(server): handle Deno compatibility in public dir copy#5852chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Deno compatibility issue where copying the public directory fails by adding a workaround to remove existing directories before copying. It also improves error message clarity.
- Adds Deno detection constant and conditional directory removal before copying
- Updates error message to be more descriptive and user-friendly
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/constants.ts | Adds isDeno boolean constant for runtime detection |
| packages/core/src/plugins/server.ts | Implements Deno-specific workaround and improves error messaging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the issue where it fails to copy the public directory when running in Deno by first removing the existing directory, if present.
Also improve the clarity of the error message.
Related Links
resolve #5804
Checklist