feat(client): improve log messages for overlay and socket#5849
Merged
chenjiahan merged 2 commits intomainfrom Aug 15, 2025
Merged
feat(client): improve log messages for overlay and socket#5849chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes log message format and improves their clarity by adding consistent [rsbuild] prefixes and making messages more descriptive and actionable.
- Standardized all log messages to use lowercase
[rsbuild]prefix instead of mixed case variations - Enhanced message clarity with more descriptive text and actionable guidance
- Added a new connection attempt log message for better debugging visibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/client/overlay.ts | Updated error overlay log messages with consistent formatting and clearer descriptions |
| packages/core/src/client/hmr.ts | Standardized HMR and WebSocket log messages with improved clarity and added connection attempt logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[rsbuild]prefixChecklist