chore: enable no-unsafe-enum-comparison lint rule#5833
Merged
chenjiahan merged 1 commit intomainfrom Aug 13, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables stricter TypeScript linting by activating the @typescript-eslint/no-unsafe-enum-comparison rule and fixes related type safety issues. The changes ensure enum values are used with proper type annotations rather than plain strings.
- Enabled the
no-unsafe-enum-comparisonESLint rule for better type safety - Updated function parameters to use
TracePresetenum type instead ofstring - Added explicit type casting where needed to maintain compatibility
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rslint.json | Removes the disabled state of the no-unsafe-enum-comparison rule |
| packages/core/src/plugins/rspackProfile.ts | Updates function signatures to use TracePreset enum type and adds type casting |
| package.json | Upgrades @rslint/core dependency from 0.1.7 to 0.1.9 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typescript-eslint/no-unsafe-enum-comparisonrule fromrslint.json@rslint/corefrom version 0.1.7 to 0.1.9Checklist