fix(hmr): remove redundant condition check#5828
Merged
chenjiahan merged 1 commit intomainfrom Aug 13, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant condition checks in the Hot Module Replacement (HMR) client code to improve code maintainability. The change eliminates an unnecessary isUpdateAvailable() check since the tryApplyUpdates() function already performs this validation internally.
- Removed redundant
isUpdateAvailable()condition inhandleApplyUpdatesfunction - Simplified control flow by relying on existing validation in
tryApplyUpdates()
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant condition check in the
handleSuccessmethod sincetryApplyUpdates()already checks for updates.Checklist