feat: add experimental ESM output support for node target#5823
Merged
chenjiahan merged 3 commits intomainfrom Aug 12, 2025
Merged
feat: add experimental ESM output support for node target#5823chenjiahan merged 3 commits intomainfrom
chenjiahan merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds experimental ESM output support for node targets by introducing a new output.module configuration option. This enables developers to generate JavaScript files in ES modules format when targeting Node.js environments.
- Introduces a new
output.moduleboolean configuration option to enable ESM output - Implements a new ESM plugin that automatically configures Rspack for ESM output when enabled
- Updates existing test configurations to use the new simplified ESM configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/config.ts | Adds module property to output configuration types with experimental annotation |
| packages/core/src/plugins/esm.ts | New plugin implementing ESM-specific Rspack configurations and node target validation |
| packages/core/src/defaultConfig.ts | Sets default value for module configuration to false |
| packages/core/src/createRsbuild.ts | Registers the new ESM plugin in the default plugin list |
| e2e/cases/server/ssr/rsbuild.config.ts | Updates test to use simplified ESM configuration |
| e2e/cases/server/ssr-type-module/rsbuild.config.ts | Replaces manual Rspack configuration with new ESM option |
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
output.moduleconfig to enable experimental ESM output format when target is node. This includes adding a new plugin to handle ESM-specific Rspack configurations and updating related type definitions and test cases.The feature is marked as experimental and currently only supports node target. This provides a foundation for future ESM support in other targets.
Related Links
Checklist