fix(cli): ensure consistent spacing for npx of node 20+#5791
Merged
chenjiahan merged 1 commit intomainfrom Aug 7, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CLI spacing inconsistencies in Node.js 20+ by updating the npx detection logic. The previous method using npm_execpath.includes('npx-cli.js') no longer works in newer Node.js versions.
- Updates npx detection to use
process.env.npm_lifecycle_event === 'npx'instead of checking the execpath - Simplifies the spacing logic by adding a prefix to the greeting message rather than logging a separate blank line
- Maintains consistent output formatting across different package managers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Node.js >= 20, we can no longer use
npm_execpath.includes('npx-cli.js')to identify npx.This PR uses
process.env.npm_lifecycle_event === 'npx'instead.Before
After
Checklist