refactor: remove unnecessary async and update type definitions#5777
Merged
chenjiahan merged 1 commit intomainfrom Aug 6, 2025
Merged
refactor: remove unnecessary async and update type definitions#5777chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary async keywords from functions that don't perform asynchronous operations and updates related type definitions to be synchronous. The change enables the @typescript-eslint/require-await ESLint rule to catch future violations where async is used without await.
- Removes
asyncfrom functions that don't useawaitoperations - Updates type definitions to allow both synchronous and asynchronous functions where appropriate
- Enables the
@typescript-eslint/require-awaitrule in the ESLint configuration
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/start/index.mdx | Updates Rslint description from "代码分析工具" to "代码检查工具" |
| README.zh-CN.md | Updates Rslint description from "代码分析工具" to "代码检查工具" |
| rslint.json | Enables the @typescript-eslint/require-await rule |
| packages/plugin-*/src/index.ts | Removes unnecessary async from bundler chain modification functions |
| packages/core/src/types/rsbuild.ts | Updates type definitions to allow synchronous providers |
| packages/core/src/**/*.ts | Removes async from functions that don't use await |
| packages/compat/webpack/src/webpackConfig.ts | Removes await from synchronous function call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typescript-eslint/require-awaitrule of Rslint.Checklist