fix(server): remove unused socket messages#5740
Merged
chenjiahan merged 1 commit intomainfrom Aug 2, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes unused Socket message types from the HMR (Hot Module Replacement) system to simplify the codebase. The PR eliminates the hot and invalid message types that are no longer consumed by the HMR client.
- Removes unused
SocketMessageHotandSocketMessageInvalidtype definitions - Eliminates the unused
singleWritemethod andhotmessage initialization - Removes the
invalidmessage dispatch in the compilation manager
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/server/socketServer.ts | Removes unused message type definitions, singleWrite method, and hot message initialization |
| packages/core/src/server/compilationManager.ts | Removes the dispatch of unused invalid message type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request simplifies the Socket server by removing unused message types and redundant methods. The
hotandinvalidmessages are no longer used by the HMR client, so we don't need to send these messages.Checklist