refactor: socket message types#5735
Merged
chenjiahan merged 2 commits intomainfrom Aug 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances type safety for socket messages by replacing loosely typed structures with strongly typed union types. The refactoring improves maintainability and provides better type checking throughout the socket communication system.
- Replaced generic
SocketMessageinterface with specific typed variants for different message types - Updated socket write functions to use proper type constraints and data validation
- Added type assertions and improved type safety in client-side message handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/server/socketServer.ts | Defines new strongly typed socket message variants and adds conditional hash sending |
| packages/core/src/server/devServer.ts | Updates SockWrite type to use type constraints and adds type assertion |
| packages/core/src/client/hmr.ts | Imports socket message types and adds type annotation for message parsing |
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces type safety improvements of socket messages. The primary changes include replacing loosely typed structures with a strongly typed
SocketMessageunion, updating related functions to use these types, and simplifying the codebase for better maintainability.Checklist