fix(types): type error when importing SVG file with React query#5587
Merged
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom Jul 12, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chenjiahan
reviewed
Jul 12, 2025
| import React from "react"; | ||
| const ReactComponent: React.FunctionComponent<React.SVGProps<SVGSVGElement>>; | ||
| export default ReactComponent; | ||
| export { ReactComponent }; |
Member
There was a problem hiding this comment.
I would prefer to remove the named export, since this is not the default behavior of @rsbuild/plugin-svgr. When users set exportType: 'named', they can refer to this guide to update the type declaration.
Suggested change
| export { ReactComponent }; |
chenjiahan
reviewed
Jul 12, 2025
This was referenced Jul 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
After
type declaration should go in template project since
rsbuild/coredoesn't depend on React