Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a deprecation notice for Node.js 16 support in both Chinese and English quick-start guides.
- Inserts a tip block warning that Rsbuild v1.5+ will drop Node.js 16.
- Updates both
quick-start.mdxfiles underwebsite/docs/zhandwebsite/docs/en.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/docs/zh/guide/start/quick-start.mdx | Added tip about Node.js 16 deprecation |
| website/docs/en/guide/start/quick-start.mdx | Added tip about Node.js 16 deprecation |
Comments suppressed due to low confidence (1)
website/docs/zh/guide/start/quick-start.mdx:36
- [nitpick] For consistency with the English version and standard version notation, consider using the “≥” symbol instead of “>=”: “Rsbuild ≥ 1.5 将不再支持 Node.js 16。”
Rsbuild >= 1.5 将不再支持 Node.js 16。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the documentation for Rsbuild's quick start guide to inform users about the upcoming deprecation of Node.js 16 in Rsbuild v1.5 and later.
Checklist