chore(plugin-svgr): improve SVGR options type#5541
Merged
chenjiahan merged 2 commits intomainfrom Jul 5, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Improve the SVGR options type to ensure the svgoConfig property uses the correct SvgoConfig type and resolves type issues in the Rspack ecosystem CI.
- Rename imported
Configfrom@svgr/coretoBaseSvgrOptionsand define a newSvgrOptionsalias - Override
svgoConfigwith the correctSvgoConfigand make it optional - Update the
deepmergecall’s generic type to require bothsvgoandsvgoConfig
Comments suppressed due to low confidence (2)
packages/plugin-svgr/src/index.ts:165
- Consider adding unit tests for the SVGR plugin to verify that custom
svgoConfigoptions are correctly merged and applied at runtime.
>(
packages/plugin-svgr/src/index.ts:9
- [nitpick] Please add a brief comment explaining why
svgoConfigis omitted fromBaseSvgrOptionsand redefined, so future maintainers understand the override rationale.
type SvgrOptions = Omit<BaseSvgrOptions, 'svgoConfig'> & {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the SVGR options type to fix rspack-ecosystem-ci.
Related Links
Checklist