fix: remove invalid resource query for scripts#5503
Merged
chenjiahan merged 1 commit intomainfrom Jun 29, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with resource queries for scripts by removing the unsupported "inline" query from the regex. Key changes include updates to snapshot tests across multiple plugins and a modification to the resourceQuery in the swc plugin.
- Update snapshot tests in plugin-svelte, plugin-react, plugin-babel, plugin-swc, environments, default, and builder snapshots.
- Modify the resourceQuery in the swc plugin from /raw|inline/ to /raw/.
- Ensure consistent handling of resource queries for scripts across the codebase.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-svelte/tests/snapshots/index.test.ts.snap | Updated resourceQuery regex |
| packages/plugin-react/tests/snapshots/index.test.ts.snap | Updated resourceQuery regex |
| packages/plugin-babel/tests/snapshots/index.test.ts.snap | Updated resourceQuery regex |
| packages/core/tests/snapshots/swc.test.ts.snap | Updated resourceQuery regex |
| packages/core/tests/snapshots/environments.test.ts.snap | Updated resourceQuery regex |
| packages/core/tests/snapshots/default.test.ts.snap | Updated resourceQuery regex |
| packages/core/tests/snapshots/builder.test.ts.snap | Updated resourceQuery regex |
| packages/core/src/plugins/swc.ts | Updated resourceQuery regex and comment for clearer intent |
| packages/compat/webpack/tests/snapshots/default.test.ts.snap | Updated resourceQuery regex |
Comments suppressed due to low confidence (1)
packages/core/src/plugins/swc.ts:120
- The updated comment now references
foo.jsinstead offoo.css, which may be confusing. Please verify and update the comment to accurately reflect that the resource query change applies specifically to script files.
// exclude `import './foo.js?raw'`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I made a mistake in #5353, the
resourceQuery({ not: /raw|inline/ })should beresourceQuery({ not: /raw/ })as the inline query are not supported for scripts.Checklist