feat: update open to v10 and improve error handling#5500
Merged
chenjiahan merged 5 commits intomainfrom Jun 28, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the open dependency from v8 to v10 (pure ESM) and adjusts bundling/configuration accordingly.
- Replace compiled import of
openwith direct ESM import inopenBrowser - Remove
openfrom the prebundle config and Renovate ignore list - Bump
opento v10.1.2 and adjust package exports
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/server/open.ts | Switched dynamic import from compiled path to ESM import of open |
| packages/core/prebundle.config.mjs | Removed open from prebundle dependencies |
| packages/core/package.json | Bumped open version; changed exports.import to CJS build |
| .github/renovate.json5 | Removed open from pure ESM ignore list |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/core/package.json:19
- The
exports.importfield points to the CJS build. To let ESM consumers load the proper bundle, consider pointing this to the ESM output (e.g.,./dist/index.js).
"import": "./dist/index.cjs",
packages/core/src/server/open.ts:102
- The fallback branch using
import('open')isn't covered by existing tests. Adding a unit test for theopenBrowserpath (both success and failure) would help ensure correct behavior.
try {
This was referenced Jun 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openfrom v8 to v10prebundle.openpackage, we should no longer need to recognize CodeSandbox (this requires further testing)Related Links
--openfails vitejs/vite#16726Checklist