chore: move all pnpm settings to pnpm-workspace.yaml#5481
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom Jun 25, 2025
Merged
Conversation
|
|
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the patchedDependencies configuration from package.json to pnpm-workspace.yaml to centralize pnpm settings.
- Patched dependencies are now defined in pnpm-workspace.yaml.
- Removed the redundant patchedDependencies configuration block from package.json.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Added a patchedDependencies section to configure patches. |
| package.json | Removed the patchedDependencies configuration from pnpm. |
Comments suppressed due to low confidence (2)
pnpm-workspace.yaml:12
- Consider updating the project documentation to reflect that patchedDependencies are now managed in pnpm-workspace.yaml, ensuring that all team members and tooling are informed of this change.
patchedDependencies:
package.json:56
- Removal of the patchedDependencies configuration from package.json aligns with centralizing the settings; verify that any tooling or scripts referencing this configuration are updated accordingly.
"node": ">=18.0.0",
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that it seems the best approach seems to be to move all the settings to pnpm-workspace.yaml.
Related Links
https://github.com/orgs/pnpm/discussions/9037
https://github.com/pnpm/pnpm/blob/main/pnpm-workspace.yaml#L334
https://github.com/vitejs/vite/pull/19895/files
Checklist