fix: correct environment check for devtool filename template#5477
Merged
chenjiahan merged 1 commit intomainfrom Jun 24, 2025
Merged
fix: correct environment check for devtool filename template#5477chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the previous NODE_ENV string check with the isDev flag for setting devtoolModuleFilenameTemplate, ensuring more accurate environment detection.
- switch environment check from
env === 'development'toisDev - remove unused
envparameter frommodifyBundlerChaincallback - update snapshot to include
devtoolModuleFilenameTemplate
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/plugins/basic.ts | Use isDev instead of env for the source-map filename template |
| packages/core/tests/snapshots/default.test.ts.snap | Add devtoolModuleFilenameTemplate entry to the default snapshot |
Comments suppressed due to low confidence (1)
packages/core/src/plugins/basic.ts:85
- Consider adding a test case for the production scenario (
isDev = false) to verify thatdevtoolModuleFilenameTemplateis not set when not in development mode.
if (isDev) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct environment check for
devtoolModuleFilenameTemplate. UsingisDev(mode) to judge will be more accurate than using NODE_ENV.Checklist