fix: lazy compilation port replacement#5470
Merged
chenjiahan merged 2 commits intomainfrom Jun 23, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes the lazy compilation port-placeholder replacement into the lazyCompilation plugin and re-enables the corresponding E2E test.
- Moved placeholder-replacement logic out of
devMiddlewares.tsintolazyCompilation.ts - Updated
pluginLazyCompilationto applyreplacePortPlaceholder - Re-enabled the E2E test for port-placeholder replacement on non-Windows platforms
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/server/devMiddlewares.ts | Removed inline port-replacement and cleaned up unused import |
| packages/core/src/plugins/lazyCompilation.ts | Added replacePortPlaceholder logic when configuring serverUrl |
| e2e/cases/lazy-compilation/port-placeholder/index.test.ts | Unskipped and updated test for port-placeholder behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devMiddlewares.tstolazyCompilation.ts, ensuring it is applied consistently.Checklist