fix: should set output charset for swc-loader#5412
Merged
chenjiahan merged 4 commits intomainfrom Jun 18, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SWC loader configuration to propagate the output charset from the normalized environment config.
- Refactor
getDefaultSwcConfigto accept an object includingconfig - Add
jsc.output.charsetbased onconfig.output.charset - Update all call sites to pass the new parameter object
Comments suppressed due to low confidence (3)
packages/core/src/plugins/swc.ts:65
- [nitpick] The parameter named
configshadows the outerconfigvariable; consider renaming it (e.g.,envConfig) for clarity.
function getDefaultSwcConfig({
packages/core/src/plugins/swc.ts:65
- [nitpick] Consider adding or updating a JSDoc comment for
getDefaultSwcConfigto document the newoutput.charsetsetting.
function getDefaultSwcConfig({
packages/core/src/plugins/swc.ts:89
- There's no existing test verifying that
output.charsetis correctly set; consider adding a unit test to cover this new behavior.
output: {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set the
charsetoption of swc-loader to ensure that the charset is consistent in all cases.Related Links
jsc.output.charsetof swc-loader rspack#10668Checklist