test(ut): fix all type issues#5340
Merged
chenjiahan merged 1 commit intomainfrom Jun 1, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses type issues in unit tests by updating type annotations and refining test contexts.
- Updated tsconfig.json to include additional type definitions.
- Updated resolve and html tests to use more explicit type casts and context stubs.
- Refined helper and CSS tests to resolve type conflicts and ensure proper PostCSS configuration handling.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/tests/tsconfig.json | Included additional type file to support type definitions in tests. |
| packages/core/tests/resolve.test.ts | Added an explicit type cast for resolve.alias to suppress type warnings. |
| packages/core/tests/html.test.ts | Passed a stub context to pluginHtml to satisfy updated type annotations. |
| packages/core/tests/helpers.test.ts | Updated import path and cast for InternalContext to resolve type conflicts. |
| packages/core/tests/define.test.ts | Removed an unused test parameter for cleaner test signature. |
| packages/core/tests/css.test.ts | Added type checks for PostCSS config to ensure plugins are set only when options are objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates type annotations and mock contexts to fix all type issues in unit test cases.
Checklist