refactor: replace querystring parse with URLSearchParams#5310
Merged
chenjiahan merged 1 commit intomainfrom May 26, 2025
Merged
refactor: replace querystring parse with URLSearchParams#5310chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the use of Node’s querystring.parse with the standardized URLSearchParams, removing the querystring import and updating query parsing logic.
- Removed the deprecated
querystringmodule import - Swapped
parse(queryStr)calls forObject.fromEntries(new URLSearchParams(queryStr)) - Minor whitespace adjustment after dynamic import
Comments suppressed due to low confidence (1)
packages/core/src/server/socketServer.ts:120
- Consider adding unit tests for the new
URLSearchParamsparsing logic, especially for edge cases like duplicate keys or query strings starting with?to ensure behavior matches the previous implementation.
queryStr ? Object.fromEntries(new URLSearchParams(queryStr)) : {}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rplacing the Node.js
querystringmodule withURLSearchParamsand removing the import. The performance difference should be minimal in this scenario.Checklist