perf: remove node:assert import#5309
Merged
chenjiahan merged 1 commit intomainfrom May 26, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the runtime assertion by replacing it with a TypeScript type assertion to improve performance.
- Removes the node:assert import and the corresponding runtime check in favor of a compile-time type assertion.
- Updates the destructuring assignment for userConfig in splitChunks.ts.
Comments suppressed due to low confidence (1)
packages/core/src/plugins/splitChunks.ts:153
- Replacing the runtime assertion with a type assertion removes runtime validation for the userConfig strategy. Please ensure that this invariant is verified elsewhere or add a clarifying comment to explain why it's safe to rely solely on TypeScript's type checking here.
const { override, forceSplittingGroups, defaultConfig, userConfig } =
ctx as SplitChunksContext & { userConfig: SplitBySize };
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replacing an
assertstatement with a TypeScript type assertion and removing the imports accordingly.Checklist