perf: use dynamic imports for readline#5308
Merged
chenjiahan merged 1 commit intomainfrom May 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve performance by converting the synchronous import of the node:readline module to a dynamic (asynchronous) import. Key changes include:
- Wrapping the cliShortcuts setup in an async-await pattern in both production and development servers.
- Updating the signature of setupCliShortcuts to return a Promise.
- Using dynamic import to load the node:readline module when needed.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/server/prodServer.ts | Awaits setupCliShortcuts to align with the new asynchronous API usage. |
| packages/core/src/server/devServer.ts | Adjusts beforeCreateCompiler and its calls to await the asynchronous setup. |
| packages/core/src/server/cliShortcuts.ts | Updates cliShortcuts function to use dynamic import for node:readline. |
❌ Deploy Preview for rsbuild failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dynamically importing the
node:readlinemodule for performance.Checklist