perf: use dynamic imports for exec and promisify#5307
Merged
chenjiahan merged 1 commit intomainfrom May 26, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the openBrowser function to improve performance by deferring the loading of node's child_process and util modules using dynamic imports.
- Removed static imports for exec and promisify.
- Moved dynamic import logic inside the if block for using AppleScript.
Comments suppressed due to low confidence (1)
packages/core/src/server/open.ts:70
- [nitpick] The inline definition of getDefaultBrowserForAppleScript duplicates functionality that was previously defined at file scope. Consider centralizing this logic to reduce redundancy.
/**
* Find the browser that is currently running
*/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the
openBrowserfunction to improve performance by deferring the loading of certain modules until they are needed.Checklist