fix: correct plugin modification warning logic#5302
Merged
chenjiahan merged 1 commit intomainfrom May 23, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the warning logic in modifyRsbuildConfig so that no warning is printed when modified.plugins is undefined by treating it as an empty array.
- Changed the conditional to use a default count of 0 when
modified.pluginsisundefined. - Introduced a
newPluginsCountvariable for clarity.
Comments suppressed due to low confidence (1)
packages/core/src/provider/initConfigs.ts:36
- Add a unit test for the case when
modified.pluginsisundefinedto verify that no warning is emitted.
const newPluginsCount = modified.plugins?.length ?? 0;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the plugin modification warning logic, if the
modifiedConfig.pluginsisundefined, we should not print a warning.Related Links
modifyRsbuildConfig#5293Checklist