fix: add warning for modifying plugins in modifyRsbuildConfig#5293
Merged
chenjiahan merged 1 commit intomainfrom May 22, 2025
Merged
fix: add warning for modifying plugins in modifyRsbuildConfig#5293chenjiahan merged 1 commit intomainfrom
modifyRsbuildConfig#5293chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a warning to notify users when the plugin count changes during the execution of modifyRsbuildConfig.
- Introduces a check to record the initial plugin count before hook execution.
- Logs a warning if the plugin count changes after the hook modifies the configuration.
This was referenced May 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a check to compare the plugin count before and after the
modifyRsbuildConfighook execution. If the plugin count changes, a warning is logged to inform users that modifying plugins at this stage is not allowed.Checklist