test(e2e): enable reloading env files case#5292
Merged
chenjiahan merged 3 commits intomainfrom May 22, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the reload-env end-to-end test by removing the test.skip directive and replacing it with a rspackOnlyTest wrapper, ensuring the test runs only under the appropriate configuration.
- Removed test.skip and integrated rspackOnlyTest for selective test execution
- Updated the process environment for the dev server by explicitly setting NODE_ENV to 'development'
Comments suppressed due to low confidence (1)
e2e/cases/cli/reload-env/index.test.ts:51
- [nitpick] Using devProcess.kill() may abruptly terminate the process; consider a more graceful shutdown approach (for example, sending SIGTERM) to allow for proper cleanup.
devProcess.kill();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enables the
reload-envE2E test and removes the previoustest.skipdirective.Checklist