test(e2e): add cases for template conditional statements#5290
Merged
chenjiahan merged 2 commits intomainfrom May 21, 2025
Merged
test(e2e): add cases for template conditional statements#5290chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds end-to-end test cases to verify various conditional statements in an HTML template.
- Introduces a template with basic
if,if/else,if/elseif/else, nestedif, and conditional expression examples - Configures template parameters in
rsbuild.config.tsto drive each conditional scenario - Implements Playwright tests asserting the presence or absence of specific rendered output
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e/cases/html/template-conditional-statement/src/index.html | Added HTML examples for multiple conditional statements |
| e2e/cases/html/template-conditional-statement/rsbuild.config.ts | Set up templateParameters for each test scenario |
| e2e/cases/html/template-conditional-statement/index.test.ts | New Playwright tests to validate rendered conditional outputs |
Comments suppressed due to low confidence (1)
e2e/cases/html/template-conditional-statement/index.test.ts:20
- Only the
value > 5branch is tested here. Consider adding a separate test scenario wherevalue <= 5to verify the else branch renders correctly.
// if/else if/else statement (value: 7)
This was referenced May 21, 2025
Merged
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds new E2E test cases for validating the rendering of conditional statements in HTML templates.
Checklist