fix(plugin-svelte): transpile the Svelte package to downgrade the syntax#5272
Merged
chenjiahan merged 2 commits intomainfrom May 19, 2025
Merged
fix(plugin-svelte): transpile the Svelte package to downgrade the syntax#5272chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Svelte plugin to transpile the Svelte package, ensuring that newer syntax (e.g., optional chaining) is downgraded. Key changes include:
- Importing EnvironmentConfig from @rsbuild/core.
- Adding an environment configuration hook via api.modifyEnvironmentConfig.
- Integrating the transpilation logic conditioned on the Svelte version.
Comments suppressed due to low confidence (1)
packages/plugin-svelte/src/index.ts:81
- [nitpick] Ensure that the regex pattern correctly captures all intended Svelte package paths across different environments. It might be useful to note any assumptions about path separators for future reference.
include: [/node_modules[\/]svelte[\/]/],
This was referenced May 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transpile the Svelte package to downgrade the syntax. The package contains ES2020 syntax, such as optional chaining.
Checklist