Skip to content

fix(mf): allow to set server.cors with built-in MF plugin#5201

Merged
chenjiahan merged 1 commit intomainfrom
mf_cors_builtin_0509
May 8, 2025
Merged

fix(mf): allow to set server.cors with built-in MF plugin#5201
chenjiahan merged 1 commit intomainfrom
mf_cors_builtin_0509

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

When MF application sets both server.cors and moduleFederation.options, server.cors should read the value set by the user instead of forcing it to true.

Related Links

#5200

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented May 8, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 81ab310
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/681cba7761eefb00085b5c18
😎 Deploy Preview https://deploy-preview-5201--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit e0cf6d4 into main May 8, 2025
12 checks passed
@chenjiahan chenjiahan deleted the mf_cors_builtin_0509 branch May 8, 2025 14:25
@chenjiahan chenjiahan mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant