Skip to content

feat: validate duplicated manifest filenames and throw a warning#5165

Merged
chenjiahan merged 1 commit intomainfrom
manifest_filenames_0505
May 5, 2025
Merged

feat: validate duplicated manifest filenames and throw a warning#5165
chenjiahan merged 1 commit intomainfrom
manifest_filenames_0505

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Validate duplicated manifest filenames and throw a warning.

For example:

export default defineConfig({
  output: {
    manifest: true,
  },
  environments: {
    web: {},
    node: {
      output: {
        target: 'node',
      },
    },
  },
});

Should be:

export default defineConfig({
  environments: {
    web: {
      output: {
        manifest: true,
      },
    },
    node: {
      output: {
        target: 'node',
        manifest: {
          filename: 'manifest-node.json',
        },
      },
    },
  },
});

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented May 5, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 0e68420
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6818a4dd5a24850008fca7a3
😎 Deploy Preview https://deploy-preview-5165--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 2da35e7 into main May 5, 2025
12 checks passed
@chenjiahan chenjiahan deleted the manifest_filenames_0505 branch May 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant