Skip to content

fix: do not generate resource hints for inlined assets#5067

Merged
chenjiahan merged 2 commits intomainfrom
resource_hints_inlined_0421
Apr 21, 2025
Merged

fix: do not generate resource hints for inlined assets#5067
chenjiahan merged 2 commits intomainfrom
resource_hints_inlined_0421

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Apr 21, 2025

Summary

If the asset is inlined via output.inlineScripts or output.inlineStyles, it will be added to the HTML content directly, so we need to exclude it from the resource hints.

Example:

export default {
  output: {
    inlineScripts: {
      enable: 'auto',
      test: /\.js$/,
    },
    inlineStyles: {
      enable: 'auto',
      test: /\.css$/,
    },
  },
  performance: {
    preload: true,
  },
}

Note that the function usage of inlineScripts and inlineStyles is not yet supported, as it requires the size param.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 99e8056
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6805f0a981bb460008145048
😎 Deploy Preview https://deploy-preview-5067--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit e4d1212 into main Apr 21, 2025
12 checks passed
@chenjiahan chenjiahan deleted the resource_hints_inlined_0421 branch April 21, 2025 07:48
@chenjiahan chenjiahan mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant