chore: add create-rsbuild devDependencies for a better type#5041
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom Apr 18, 2025
Merged
chore: add create-rsbuild devDependencies for a better type#5041chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Apr 17, 2025
| "@rsbuild/plugin-react": "workspace:*", | ||
| "@rsbuild/plugin-solid": "workspace:*", | ||
| "@rsbuild/plugin-svelte": "workspace:*", | ||
| "@rsbuild/plugin-vue2": "^1.0.2", |
Member
There was a problem hiding this comment.
We do not want to install @rsbuild/plugin-vue2 in this repo, as Vue 2 has reached EOL.
Member
There was a problem hiding this comment.
I'm curious, do the type issues in templates cause any problems?
Contributor
Author
There was a problem hiding this comment.
Just a type error in the code editor, no other problems. 😄
Member
There was a problem hiding this comment.
Get, I will merge this PR and apply some updates. Thank you
chenjiahan
approved these changes
Apr 18, 2025
This was referenced Apr 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
fix
Checklist