Skip to content

fix: appendPlugins not work in some cases#4767

Merged
chenjiahan merged 2 commits intomainfrom
append_plugins_0312
Mar 12, 2025
Merged

fix: appendPlugins not work in some cases#4767
chenjiahan merged 2 commits intomainfrom
append_plugins_0312

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

Fix appendPlugins method of tools.rspack not work in some cases.

webpack-merge will generate new configuration objects and this PR uses Proxy to ensure the utils can always access the latest configuration object.

Related Links

resolve #4759

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 12, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit bd012ee
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67d11b8adc84bf000863d274
😎 Deploy Preview https://deploy-preview-4767--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit f07b56c into main Mar 12, 2025
12 checks passed
@chenjiahan chenjiahan deleted the append_plugins_0312 branch March 12, 2025 05:45
@chenjiahan chenjiahan mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: rspack plugins of configs are not merged correctly when using both object and function

1 participant