Skip to content

feat(plugin-webpack-swc): use require.resolve to check react version to support pnpm catalog#4745

Merged
chenjiahan merged 4 commits intomainfrom
fix/check-react-version
Mar 10, 2025
Merged

feat(plugin-webpack-swc): use require.resolve to check react version to support pnpm catalog#4745
chenjiahan merged 4 commits intomainfrom
fix/check-react-version

Conversation

@caohuilin
Copy link
Copy Markdown
Member

@caohuilin caohuilin commented Mar 10, 2025

Summary

use require.resolve to check react version to support pnpm catalog

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 10, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 5a423a0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67ce8306c6573c0008cc16e4
😎 Deploy Preview https://deploy-preview-4745--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@caohuilin caohuilin force-pushed the fix/check-react-version branch from b929f75 to 490efb5 Compare March 10, 2025 05:48
caohuilin and others added 2 commits March 10, 2025 14:06
@caohuilin caohuilin force-pushed the fix/check-react-version branch from c21a39e to ed446e0 Compare March 10, 2025 06:06
chenjiahan
chenjiahan previously approved these changes Mar 10, 2025
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@chenjiahan chenjiahan enabled auto-merge (squash) March 10, 2025 06:10
@chenjiahan chenjiahan changed the title feat: use require.resolve to check react version to support pnpm catalog feat(plugin-webpack-swc): use require.resolve to check react version to support pnpm catalog Mar 10, 2025
@caohuilin
Copy link
Copy Markdown
Member Author

@chenjiahan I fixed the lint error. It needs to be approved again ❤️

@chenjiahan chenjiahan merged commit cff6825 into main Mar 10, 2025
11 checks passed
@chenjiahan chenjiahan deleted the fix/check-react-version branch March 10, 2025 06:43
@chenjiahan chenjiahan mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants