Skip to content

chore(style): standardize logging messages#4642

Merged
chenjiahan merged 5 commits intomainfrom
log_standard_0223
Feb 24, 2025
Merged

chore(style): standardize logging messages#4642
chenjiahan merged 5 commits intomainfrom
log_standard_0223

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

This pull request includes several changes to enforce a consistent logging message case convention across the codebase.

/**
 * Logging message case convention:
 *
 * Info, ready, success and debug messages:
 * - Start with lowercase
 * - Example: "info  build started..."
 *
 * Errors and warnings:
 * - Start with uppercase
 * - Example: "error  Failed to build"
 *
 * This convention helps distinguish between normal operations
 * and important alerts that require attention.
 */

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 23, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 8ec5a5b
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67bb2374f1f67f00081868f4
😎 Deploy Preview https://deploy-preview-4642--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 48 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 23, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ca48436
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67bb23ae7150630008e38cb3
😎 Deploy Preview https://deploy-preview-4642--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit ffbafc8 into main Feb 24, 2025
11 checks passed
@chenjiahan chenjiahan deleted the log_standard_0223 branch February 24, 2025 01:03
nice-hang pushed a commit to nice-hang/rsbuild that referenced this pull request Feb 24, 2025
@chenjiahan chenjiahan mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant