fix: prevent some hook return values from affecting other hooks#4569
Merged
chenjiahan merged 1 commit intomainfrom Feb 15, 2025
Merged
fix: prevent some hook return values from affecting other hooks#4569chenjiahan merged 1 commit intomainfrom
chenjiahan merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR distinguishes the
callmethod of Rsbuild's internal hook intocallBatchandcallChainto prevent some hook return values from affecting other hooks.callBatch: Each callback receives the original parameters, and their results don't affect subsequent callbacks. For example,onBeforeBuildandonAfterBuildhooks.callChain: Passing the result of each callback as the first argument to the next callback in the chain. If a callback returns undefined, the original arguments will be passed to the next callback. For example,modifyRspackConfigandmodifyRsbuildConfighooks.Checklist