Skip to content

fix: prevent some hook return values from affecting other hooks#4569

Merged
chenjiahan merged 1 commit intomainfrom
hook_return_value_0215
Feb 15, 2025
Merged

fix: prevent some hook return values from affecting other hooks#4569
chenjiahan merged 1 commit intomainfrom
hook_return_value_0215

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Summary

This PR distinguishes the call method of Rsbuild's internal hook into callBatch and callChain to prevent some hook return values from affecting other hooks.

  • callBatch: Each callback receives the original parameters, and their results don't affect subsequent callbacks. For example, onBeforeBuild and onAfterBuild hooks.
  • callChain: Passing the result of each callback as the first argument to the next callback in the chain. If a callback returns undefined, the original arguments will be passed to the next callback. For example, modifyRspackConfig and modifyRsbuildConfig hooks.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 15, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 88775c3
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67b0830f25f7800008d31be0
😎 Deploy Preview https://deploy-preview-4569--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 50 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 8a378f7 into main Feb 15, 2025
15 checks passed
@chenjiahan chenjiahan deleted the hook_return_value_0215 branch February 15, 2025 12:34
@chenjiahan chenjiahan mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant