fix(server): remove .mjs suffix check when loading ESM module in runner#4536
Merged
chenjiahan merged 10 commits intomainfrom Feb 14, 2025
Merged
fix(server): remove .mjs suffix check when loading ESM module in runner#4536chenjiahan merged 10 commits intomainfrom
.mjs suffix check when loading ESM module in runner#4536chenjiahan merged 10 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Feb 12, 2025
chenjiahan
reviewed
Feb 12, 2025
chenjiahan
reviewed
Feb 12, 2025
.mjs suffix check when loading esm module in runner
chenjiahan
approved these changes
Feb 14, 2025
.mjs suffix check when loading esm module in runner.mjs suffix check when loading ESM module in runner
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only rspack outputs require proxy import, so only experiments.outputModule is required for loading rspack esm outputs in runner, no
.mjssuffix is required.Related Links
Checklist