Skip to content

test(asset): add test for [path] template for Rslib#4521

Merged
SoonIter merged 1 commit intomainfrom
support-path-templat
Feb 10, 2025
Merged

test(asset): add test for [path] template for Rslib#4521
SoonIter merged 1 commit intomainfrom
support-path-templat

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Feb 10, 2025 •
edited
Loading

Summary

export default {
  output: {
    distPath: {
      image: ''
    },
	filename: {
	  image: '[path][name][ext]'
	}
  },
};

[path] only supported in generator.options but not implemented for output.filename and output.chunkFilename

so only for asset, js/jsAsync/css/cssAsync can not use [path]

image

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 10, 2025 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 24dce75
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67a9b3798861190009cfc670
😎 Deploy Preview https://deploy-preview-4521--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 49 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title feat(asset): support [path] template feat(asset): support [path] template for Rslib Feb 10, 2025
9aoy
9aoy reviewed Feb 10, 2025
View reviewed changes
Comment thread packages/core/src/plugins/asset.ts Outdated
@SoonIter SoonIter force-pushed the support-path-templat branch from f58a7ec to 12557c6 Compare February 10, 2025 08:03
@SoonIter SoonIter changed the title feat(asset): support [path] template for Rslib test(asset): add test for [path] template for Rslib Feb 10, 2025
@SoonIter SoonIter force-pushed the support-path-templat branch from 12557c6 to 24dce75 Compare February 10, 2025 08:06
@SoonIter SoonIter requested a review from 9aoy February 10, 2025 08:23
@SoonIter SoonIter merged commit d6b5922 into main Feb 10, 2025
@SoonIter SoonIter deleted the support-path-templat branch February 10, 2025 08:37
@chenjiahan chenjiahan mentioned this pull request Feb 11, 2025
Merged
@renovate renovate Bot mentioned this pull request Mar 8, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@9aoy 9aoy 9aoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SoonIter @9aoy