Skip to content

docs: fix missing admonition end indicator on inline-assets doc#4509

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
wralith:patch-1
Feb 8, 2025
Merged

docs: fix missing admonition end indicator on inline-assets doc#4509
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
wralith:patch-1

Conversation

@wralith
Copy link
Copy Markdown
Contributor

@wralith wralith commented Feb 8, 2025

Summary

Due to the missing ::: in markdown, Inline JS files section is included Do you really need to exclude assets from inlining? info part of Force no Inlining section.

image

Related Links

https://rsbuild.dev/guide/optimization/inline-assets#inline-js-files

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 8, 2025

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 8, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 087a903
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67a759411c99a30008f5675c
😎 Deploy Preview https://deploy-preview-4509--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan merged commit d68e816 into web-infra-dev:main Feb 8, 2025
@wralith wralith deleted the patch-1 branch February 8, 2025 14:02
@chenjiahan chenjiahan mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants