Skip to content

docs: fix grammar in Rsbuild description#4502

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
Brennvo:main
Feb 7, 2025
Merged

docs: fix grammar in Rsbuild description#4502
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
Brennvo:main

Conversation

@Brennvo
Copy link
Copy Markdown
Contributor

@Brennvo Brennvo commented Feb 7, 2025

Summary

Fixes grammar in the Rsbuild introduction section (which is also included in the project README).

Before:

Rsbuild shares many similarities with Vite, as they are both aim to improve the frontend development experience.

After:

Rsbuild shares many similarities with Vite, as they both aim to improve the frontend development experience.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 7, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 7, 2025 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 6e03cd0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67a67d481d0dfa0008f27245
😎 Deploy Preview https://deploy-preview-4502--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 76 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chenjiahan
chenjiahan approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenjiahan chenjiahan enabled auto-merge (squash) February 7, 2025 23:19
@chenjiahan chenjiahan merged commit 673f72d into web-infra-dev:main Feb 7, 2025
9 checks passed
@chenjiahan chenjiahan mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Brennvo @CLAassistant @chenjiahan