fix(webpack): avoid duplicate import core package#3871
Merged
chenjiahan merged 2 commits intomainfrom Oct 31, 2024
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
!eco-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #3713,
@rsbuild/webpackhas been changed to a pure ESM package (with a CJS shim wrapper).But this change introduces the dual package hazard:
@rsbuild/corewill be loaded twice times when@rsbuild/webpackis used by a CommonJS package (like Modern.js).This PR reverts
@rsbuild/webpackto a dual package to avoid this problem.Related Links
Checklist