fix: configure the default assetPrefix for MF apps correctly#3757
Merged
chenjiahan merged 2 commits intomainfrom Oct 19, 2024
Merged
fix: configure the default assetPrefix for MF apps correctly#3757chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nyqykk
approved these changes
Oct 18, 2024
Member
|
ok i will port this to universe repo |
This was referenced Oct 20, 2024
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default asset prefix has been changed when using
moduleFederation.options. These changes ensure that the assets of remote modules can be requested by consumer apps with the correct URL, and that the SPA URL fallback works as expected.dev.assetPrefix).autototrue(equivalent tolocalhost:<port>)dev.assetPrefixvalue set by user.@nyqykk please take a look, I suppose these changes should be ported to @module-federation/rsbuild-plugin
Related Links
resolve: #3751
Checklist